1318764 - Get rid of sync GetLookAndFeelCache, and send the cache with the GetXPCOMProcessAttributes message instead

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This coalesces two sync messages into one.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

Review commit: https://reviewboard.mozilla.org/r/94114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94114/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

https://reviewboard.mozilla.org/r/94114/#review95062

Please note that InfallibleTArray and nsTArray are the same. I'm not sure which one is preferred now. Maybe check with Nathan.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

https://reviewboard.mozilla.org/r/94114/#review95068

::: dom/ipc/ContentChild.h:634
(Diff revision 1)
>    InfallibleTArray<mozilla::dom::FontFamilyListEntry>&
>    SystemFontFamilyList() {
>      return mFontFamilies;
>    }
>  
> +  InfallibleTArray<LookAndFeelInt>&

Thanks!

Ah, according to froydnj, nsTArray is preferred over InfallibleTArray. I'll update the patch with that change before landing.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94114/diff/1-2/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94114/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fec5699c5c50
Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead. r=billm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fec5699c5c50