Closed
Bug 1321835
Opened 8 years ago
Closed 8 years ago
Add asserts that the "given proto", if provided, is in the right compartment in bindings code
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.68 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
We don't seem to assert that, and people are writing code that relies on implementation details and doesn't maintain that basic invariant.
| Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8816508 -
Flags: review?(peterv)
Updated•8 years ago
|
Attachment #8816508 -
Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/deadb8cb73ef
Assert that the givenProto argument for binding wrap methods is in the right compartment. r=peterv
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•