1323525 - Clicking "Change Search Settings" in searchbar doesn't work

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Tom S. (please needinfo tschuster)]

Clicking that button just does nothing on Nightly. Works with the same profile on release.

Comment 1

[Francesco Lodolo [:flod]]

It works fine here on OS X and 53.0a1 (2016-12-14). Does Nightly on a clean profile work?

Comment 2

[Marco Bonardo [:mak]]

WFM on Windows 10 as well.

Comment 3

[ovidiu boca[:Ovidiu]]

Tested on Mac OS X 10.10 with FF Nighlty 53.0a1(2016-12-18) and I can't reproduce it.

Comment 4

[Tanner Filip [:tanner]]

I can reproduce on Linux. 

13:28.10 INFO: Last good revision: 55a41c5e8e88010ea8a539c009f27b7b14988700
13:28.10 INFO: First bad revision: 3e92691272d3139d0f428bf7499bc65f7318f540
13:28.10 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55a41c5e8e88010ea8a539c009f27b7b14988700&tochange=3e92691272d3139d0f428bf7499bc65f7318f540

13:28.80 INFO: Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1113747

Comment 5

[Tanner Filip [:tanner]]

Confirmed with others that they can reproduce on Linux as well, so I'm guessing this one is platform-specific.

Comment 6

[Hussam Al-Tayeb]

Same here on Linux with nightly builds. In addition, I am unable to add search engines.

Comment 7

[Marcia Knous [:marcia]]

Tracking 53+ for this issue - ni on Drew since it appears he fixed the bug that is being referenced as causing the regression.

Comment 8

[Drew Willcoxon :adw]

Yes, I'm looking into this.

Comment 10

[Drew Willcoxon :adw]

Attachment: Bug 1323525 - Clicking "Change Search Settings" in searchbar doesn't work.

Review commit: https://reviewboard.mozilla.org/r/108310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108310/

Comment 11

[Drew Willcoxon :adw]

Bug 1113747 added the class check so that clicks on the menu button wouldn't get eaten.  Before that bug, all the mousedown handler did was the preventDefault().  The problem is the settings button and add-engine button don't have that class, so the handler returns early and skips the preventDefault(), which as the code comment indicates breaks clicks on Linux.

So instead, check specifically for the add-engine menu button.

Comment 12

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #11)
> Bug 1113747 added the class check

... and the early return.

Comment 13

[Florian Quèze [:florian]]

Comment on attachment 8831774 [details]
Bug 1323525 - Clicking "Change Search Settings" in searchbar doesn't work.

https://reviewboard.mozilla.org/r/108310/#review109908

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c752414c834
Clicking "Change Search Settings" in searchbar doesn't work. r=florian

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c752414c834

Comment 16

[Drew Willcoxon :adw]

Attachment: Aurora 53 patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1113747
[User impact if declined]: This bug
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Tiny isolated patch
[String changes made/needed]: None

Comment 17

[Gerry Chang [:gchang]]

Hi Andrei,
could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 18

[Rémy Hubscher (:natim)]

As of 54.0a1 (2017-02-01) it is not fixed in the French version of Nightly. I will try again later today to see if 54.0a1 (2017-02-02) fixes it.

Comment 19

[Andrei Vaida [:avaida]]

Forwarding this to Brindusa, who's taking care of Nightly requests.

Comment 20

[Baranitharan]

It work fine with Nightly

Comment 21

[Brindusa Tot, DTE]

Simona, could you help verify if this issue is fixed on a latest Nightly build?

Comment 22

[Simona Badau, Desktop QA]

Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Reproduced on Nightly 54.0a1 (Build ID: 20170201030207) on Ubuntu 16.04 x64.

Verified as fixed using the latest Nightly 54.0a1 (Build ID: 20170202110108) on Ubuntu 16.04 x64.

Comment 23

[Rémy Hubscher (:natim)]

I can confirm it is working as per Nightly 54.0a1 (2017-02-02)

Comment 24

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8832707 [details] [diff] [review]
Aurora 53 patch

Fix for regression from 53, verified in nightly, let's take it.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dfdab396dff7

Comment 28

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this issue is fixed, I verified using Fx 53.0a2, build ID: 20170206084021, on Ubuntu 14.04 LTS x64.