1331009 - Allow line separator between await and its expression

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Test case:
---
async function f() {
    await
        0;
}
---

Expected: Parses successfully
Actual: Throws SyntaxError

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove wrong restriction for a newline after await.

Removed wrong same-line check after TOK_AWAIT.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8834915 [details] [diff] [review]
Remove wrong restriction for a newline after await.

Review of attachment 8834915 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a16d5d08b268652f05f54fde71dc83fb60abf641
Bug 1331009 - Remove wrong restriction for a newline after await. r=till

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a16d5d08b268

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: (mozilla-aurora) Remove wrong restriction for a newline after await. r=till

Approval Request Comment
> [Feature/Bug causing the regression]
Added by bug 1185106.

> [User impact if declined]
Throws error for valid JS syntax.

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removes unnecessary restriction that has no other effect.

> [String changes made/needed]
none

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: (mozilla-beta) Remove wrong restriction for a newline after await. r=till

Approval Request Comment
> [Feature/Bug causing the regression]
Added by bug 1185106.

> [User impact if declined]
Throws error for valid JS syntax.

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removes unnecessary restriction that has no other effect.

> [String changes made/needed]
none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8835671 [details] [diff] [review]
(mozilla-aurora) Remove wrong restriction for a newline after await. r=till

don't reject valid js syntax, aurora53+

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8835672 [details] [diff] [review]
(mozilla-beta) Remove wrong restriction for a newline after await. r=till

don't reject valid js syntax, beta52+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbe0f9d9bf9d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65be24609b44

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/65be24609b44