1332951 - [EME] On Linux MediaKeySystemAccess should check whether sandboxing works before advertising keySystems

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

On Linux we only load GMPs if sandboxing is working; i.e. if seccomp-bpf is present. However, navigator.requestMediaKeySystemAccess doesn't actually check this before advertising that Widevine/ClearKey is available. So this means on Linux, we could end up reporting that we can use EME, but it actually won't work.

We should check whether SandboxInfo::Get().CanSandboxMedia() is true before assuming Widevine/ClearKey will work.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1332951 - On Linux check whether Widevine CDM can be sandboxed before advertising we support it.

We already do this in GMPParent::ReadGMPInfoFile(), and I neglected to check
this in the Chromium/Widevine manifest parsing code. This means we won't add
the GMPParent to our list of GMPParents, and so
navigator.requestMediaKeySystemAccess won't advertise that we support Widevine.

Review commit: https://reviewboard.mozilla.org/r/106394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106394/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf2d6565e5fc

Comment 3

[Jed Davis [:jld] (away until 10-15)]

Comment on attachment 8829279 [details]
Bug 1332951 - On Linux check whether Widevine CDM can be sandboxed before advertising we support it.

https://reviewboard.mozilla.org/r/106394/#review107628

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86e41df6b615
On Linux check whether Widevine CDM can be sandboxed before advertising we support it. r=jld

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/86e41df6b615