Closed
Bug 1335555
Opened 9 years ago
Closed 9 years ago
[EME] Remove MediaKeySession.keySystem
Categories
(Core :: Audio/Video: Playback, defect, P5)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: cpearce, Assigned: jay.harris)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(2 files)
We added the MediaKeySession.keySystem string a while back, and now it's no longer in the spec.
So we need to remove it from:
https://dxr.mozilla.org/mozilla-central/source/dom/webidl/MediaKeySession.webidl#19
And it's getters/setters from
https://dxr.mozilla.org/mozilla-central/source/dom/media/eme/MediaKeySession.cpp
https://dxr.mozilla.org/mozilla-central/source/dom/media/eme/MediaKeySession.h
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•9 years ago
|
Attachment #8832306 -
Flags: review?(bugs)
Attachment #8832307 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 3•9 years ago
|
||
A try push with the changes (that will hopefully not explode) https://treeherder.mozilla.org/#/jobs?repo=try&revision=00b092c11eb3258cafbc4dfc768c48d6e2db8c1a
|
||
Comment 4•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832307 [details]
Bug 1335555 - Removes a call to telemetry that is no longer needed
https://reviewboard.mozilla.org/r/108646/#review109842
This doesn't need my review.
Attachment #8832307 -
Flags: review?(bugs)
|
|
||
Comment 5•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832306 [details]
Bug 1335555 - Begins removing MediaKeySession.keySystem
https://reviewboard.mozilla.org/r/108644/#review109844
Attachment #8832306 -
Flags: review?(bugs) → review+
|
Reporter | |
Comment 6•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832306 [details]
Bug 1335555 - Begins removing MediaKeySession.keySystem
https://reviewboard.mozilla.org/r/108644/#review110058
Attachment #8832306 -
Flags: review?(cpearce) → review+
|
|
Reporter | |
Comment 7•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832307 [details]
Bug 1335555 - Removes a call to telemetry that is no longer needed
https://reviewboard.mozilla.org/r/108646/#review110062
You also need to remove the probe definition:
https://dxr.mozilla.org/mozilla-central/rev/1d025ac534a6333a8170a59a95a8a3673d4028ee/toolkit/components/telemetry/Histograms.json#9246
Attachment #8832307 -
Flags: review?(cpearce) → review-
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 9•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832307 [details]
Bug 1335555 - Removes a call to telemetry that is no longer needed
https://reviewboard.mozilla.org/r/108646/#review110120
Attachment #8832307 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 10•9 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3985bc2553aa
Begins removing MediaKeySession.keySystem r=cpearce,smaug
https://hg.mozilla.org/integration/autoland/rev/268c3d74fba3
Removes a call to telemetry that is no longer needed r=cpearce
Keywords: checkin-needed
|
||
Comment 11•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3985bc2553aa
https://hg.mozilla.org/mozilla-central/rev/268c3d74fba3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Comment 12•8 years ago
|
||
This change is now noted on Firefox 54 for devs; we had no docs when I went to update this.
Keywords: dev-doc-complete
|
||
Comment 13•8 years ago
|
||
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/mediakeysession-keysystem-has-been-removed/
Keywords: site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•