1339733 - Move GMPCrashHelperHolder implementation to its own file

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

This prevents an inclusion cycle between GMPService.h and GMPCrashHelperHolder.h in another patch I'm writing for bug 1315850.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1339733 - Move GMPCrashHelperHolder implementation into its own .cpp file.

This means we don't need to include GMPService.h in GMPCrashHelperHolder.h,
in order to use the GMPService inside GMPCrashHelperHolder.

This which prevents an inclusion cycle between GMPService.h and GMPCrashHelperHolder.h
in another patch I'm working on.

Review commit: https://reviewboard.mozilla.org/r/112588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112588/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1339733 - Move GMPCrashHelperHolder implementation into its own .cpp file.

This means we don't need to include GMPService.h in GMPCrashHelperHolder.h,
in order to use the GMPService inside GMPCrashHelperHolder.

This which prevents an inclusion cycle between GMPService.h and GMPCrashHelperHolder.h
in another patch I'm working on.

Review commit: https://reviewboard.mozilla.org/r/112592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112592/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8837472 [details]
Bug 1339733 - Move GMPCrashHelperHolder implementation into its own .cpp file.

https://reviewboard.mozilla.org/r/112592/#review114070

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a723635386
Move GMPCrashHelperHolder implementation into its own .cpp file. r=jwwang

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e4a723635386