1346098 - Don't export IntlUtils without ICU

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Makoto Kato [:m_kato]]

Bug 1341994 uses mozIMozIntl interface, but we have to support non-INTL_API on Android as official.

Comment 1

[Makoto Kato [:m_kato]]

(Since Fennec/Android uses native date time picker, IntlUtils won;t be used on Fennec/Android even if Intl API is turned on)

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

But the code for them will not be available since mozIMozIntl relies on ICU for 100% of its functionality.

Wouldn't it make more sense to disable Bug 1341994 code on Android?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> But the code for them will not be available since mozIMozIntl relies on ICU
> for 100% of its functionality.
> 
> Wouldn't it make more sense to disable Bug 1341994 code on Android?

OK, but we need a lot of ifdef into dom

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1346098 - Don't expose intlUtils without ENABLE_INTL_API.

Fennec team decides that Fennec will turn off ICU support on release build now.  So we need to able be build Firefox without ENABLE_INTL_API (Bug 1343725).
Bug 1341994 uses mozIMozIntl interface, but it is only defined with ENABLE_INTL_API.  So we shouldn't expose intlUtils if ICU is turned off.

Review commit: https://reviewboard.mozilla.org/r/118974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118974/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8845800 [details]
Bug 1346098 - Don't expose intlUtils without ENABLE_INTL_API.

https://reviewboard.mozilla.org/r/118974/#review120998

I guess this is fine. ( Really need to figure out how to have ICU on Android. )

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2ed3ad38c26
Don't expose intlUtils without ENABLE_INTL_API. r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2ed3ad38c26

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 8845800 [details]
Bug 1346098 - Don't expose intlUtils without ENABLE_INTL_API.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1343725 and bug 1341994

[User impact if declined]:
We cannot release Firefox for android on beta and release channel since we cannot build Fennec on beta/release builder.

:snorp and :blassey decides that we still keep turning off Intl API and ICU on Fennec beta/release channel.  So we require this fix to build Fennec on release and beta channel.

[Is this code covered by automated tests?]:
No, but this is build only issue

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
No, this is build issue.

[List of other uplifts needed for the feature/fix]:
Nothing.

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This is build issue only.

[String changes made/needed]:
No

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8845800 [details]
Bug 1346098 - Don't expose intlUtils without ENABLE_INTL_API.

This patch supports turning off Intl API and ICU on Fennec beta/release channel. Aurora54+.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/814932cca0c4