1348816 - Session store updates (inefficiently) - 1 observer per tab - when users select a different page style

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[:Gijs (he/him)]

https://dxr.mozilla.org/mozilla-central/rev/1b9293be51637f841275541d8991314ca56561a5/browser/components/sessionstore/content/content-sessionStore.js#462

This should ideally be using an event... but really, page styles aren't that common and are trivial to re-select, so I'm tempted to say we should just remove the auto-updating sessionstore data when selecting a different style altogether.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I agree, can we just remove this? Mike, wdyt? I'd happily take it.

Comment 2

[Mike de Boer [:mikedeboer]]

I'm indeed really just fine with removing it. The simpler the better!

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1348816-Remove-PageStyle-collection-restoration-.patch

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8888230 [details] [diff] [review]
0001-Bug-1348816-Remove-PageStyle-collection-restoration-.patch

Review of attachment 8888230 [details] [diff] [review]:
-----------------------------------------------------------------

That's a bigger cleanup than I expected! I feel much lighter already. ;-)
Can you push this to try (m-bc) to make sure we've got everything?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d00bbfd7ac832ae1fe75b779d2a18d455cc66798

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Quite a few oranges, but they seem unrelated.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee1e97fc01b
Remove PageStyle collection/restoration from SessionStore r=mikedeboer

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ee1e97fc01b