1353081 - Lazily load NetUtil.jsm in Schemas.jsm

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Andrew McCreight [:mccr8]]

NetUtils.jsm is not needed unless readJSON is called, and it doesn't seem to be called in a clean profile. (This is one of the two remaining places in a clean profile that load NetUtils.jsm on startup.)

Comment 1

[Kris Maglione [:kmag]]

Well, Schemas.jsm shouldn't be loaded in a clean profile, but we never need NetUtil.jsm in the content process or for most startups.

Comment 2

[Andrew McCreight [:mccr8]]

Ah, that's a good reason to load it lazily then. :)

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1353081 - Lazily load NetUtil.jsm in Schemas.jsm.

Review commit: https://reviewboard.mozilla.org/r/126064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126064/

Comment 4

[Andrew McCreight [:mccr8]]

I locally ran some web extension mochitests. Hopefully that's enough to smoke test a simple change like this.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8854081 [details]
Bug 1353081 - Lazily load NetUtil.jsm in Schemas.jsm.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126064/diff/1-2/

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8854081 [details]
Bug 1353081 - Lazily load NetUtil.jsm in Schemas.jsm.

https://reviewboard.mozilla.org/r/126064/#review128662

r=me, but please make sure there's no place we're doing NetUtil.newURI that can't be changed to Services.io.newURI. I'm on a phone right now, so can't check myself.

Comment 7

[Andrew McCreight [:mccr8]]

The two uses of NetUtil in Schemas.jsm are NetUtil.asyncFetch and NetUtil.readInputStreamToString.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d7dcc765725
Lazily load NetUtil.jsm in Schemas.jsm. r=kmag

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8d7dcc765725