1355758 - stylo: Element.getAnimations() returns transitions with incorrect order

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Boris Chiou [:boris]]

Bug 1341372 detects transition and make it run. However, the order of transitions are not correct, so a test is failed [1].

[1] http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/dom/animation/test/css-transitions/file_element-get-animations.html#127-143

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

We use RestyleManager::mAnimationGeneration as the animation index of a
new created transition, and Element.getAnimations() uses this index to
sort the order of transitions. We increase mAnimationGeneration one per
restyle cycle if there is any non-animation update.

Review commit: https://reviewboard.mozilla.org/r/132340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132340/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8860311 [details]
Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

https://reviewboard.mozilla.org/r/132340/#review135496

::: layout/base/ServoRestyleManager.h:152
(Diff revision 1)
>  
>    // Only non-null while processing change hints. See the comment in
>    // ProcessPendingRestyles.
>    ReentrantChangeList* mReentrantChanges;
> +
> +  bool mHaveNonAnimationRestyles = false;

Can you please put a brief comment here explaining why we need to track this state.

Comment 3

[Boris Chiou [:boris]]

Comment on attachment 8860311 [details]
Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

https://reviewboard.mozilla.org/r/132340/#review135496

> Can you please put a brief comment here explaining why we need to track this state.

OK. Sure.

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8860311 [details]
Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132340/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a418fa4ad285
Update RestyleManager::mAnimationGeneration for non-animation update. r=heycam

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a418fa4ad285