1357649 - Remove remnants of AudioChannelManager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Mike Hommey [:glandium]]

Bug 1357326 removed the b2g top-level directory. That was the only place setting MOZ_AUDIO_CHANNEL_MANAGER. I meant to remove everything related to MOZ_AUDIO_CHANNEL_MANAGER in bug 1357323 but it turns out I left some parts out. It also turns out that there's not much code with that #ifdef, so I figured I'd just go ahead and remove the whole thing.

One thing that I didn't do, though, but could be done, is that AudioChannelManager was the sole consumer of AudioChannelService::SetDefaultVolumeControlChannel, but since there's actually a SetDefaultVolumeControlChannelInternal that is used by some other code, I figured  I'd leave it there.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1357649 - Remove remnants of AudioChannelManager.

Review commit: https://reviewboard.mozilla.org/r/131492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131492/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8859458 [details]
Bug 1357649 - Remove remnants of AudioChannelManager.

https://reviewboard.mozilla.org/r/131492/#review134230

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5075b942b6f
Remove remnants of AudioChannelManager. r=bz

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5075b942b6f

Comment 5

[Chris Mills [:cmills]]

Setting straight to dev-doc-complete; this has already been archived