1360006 - Enable hardware VP9 decode on intel GPUs

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

VP9 hardware decoding works well on Intel GPUs. We should enable by default.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Jean-Yves - what do I need to do to make this happen?

Comment 2

[Jean-Yves Avenard [:jya]]

Anthony, I'm not sure the intel is that much better really... There's definitely jitter compare to the software version
I described the issue in bug 1314458.
Very noticeable playing this scene: https://youtu.be/iNJdPyoqt8U?t=44

I have a patch ready, it may be simply that people using intel GPU don't care or just don't notice :)

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1360006: Whitelist VP9 decoder to intel GPU only.

We enable by default the VP9 hardware decoder on intel GPU.

Review commit: https://reviewboard.mozilla.org/r/144962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144962/

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8873582 [details]
Bug 1360006: Whitelist VP9 decoder to intel GPU only.

https://reviewboard.mozilla.org/r/144962/#review149006

::: dom/media/platforms/wmf/DXVA2Manager.h:73
(Diff revision 1)
>    // need to take responsibility for creating a decoder and handle the related
>    // decoding operations by ourself.
>    virtual bool CreateDXVA2Decoder(const VideoInfo& aVideoInfo,
>                                    nsACString& aFailureReason) = 0;
>  
> +  virtual uint32_t GetVendorId() const { return 0; }

Might as well make this pure virtual since all subclasses implement it.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8873582 [details]
Bug 1360006: Whitelist VP9 decoder to intel GPU only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144962/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77f2dd5563d2
Whitelist VP9 decoder to intel GPU only. r=mattwoodrow

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/77f2dd5563d2