1363768 - Cache and simplify some components under Message

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

Doing some measurements, it looks like there are some easy small wins with MessageIndent, MessageRepeat, and MessageIcon

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1363768 - Prevent creating constant elements during render;

Review commit: https://reviewboard.mozilla.org/r/138234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138234/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8866629 [details]
Bug 1363768 - Prevent creating constant elements during render;

https://reviewboard.mozilla.org/r/138234/#review141464

Just a small thing, but R+ if TRY and mocha are green

::: devtools/client/webconsole/new-console-output/components/message.js:194
(Diff revision 1)
>          )));
>      } else {
>        notesNodes = [];
>      }
>  
> -    const repeat = MessageRepeat({repeat: this.props.repeat});
> +    const repeat = this.props.repeat ? MessageRepeat({repeat: this.props.repeat}) : null;

IF we're doing this here, we can go a little further and do not print anything if repeat is < 2

```
const repeat = this.props.repeat && this.props.repeat > 1 
  ? MessageRepeat({repeat: this.props.repeat}) 
  : null;
```

It also means that we can remove tis logic from the MessageRepeat function

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8866629 [details]
Bug 1363768 - Prevent creating constant elements during render;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138234/diff/1-2/

Comment 4

[Brian Grinstead [:bgrins]]

Thanks, good points.  Updated, and pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e3fe814e311328fe69e35702eaad0f0d6f3ef04

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bea7660031a0
Prevent creating constant elements during render;r=nchevobbe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bea7660031a0