1365767 - Stop bootlegging TextEncoder and TextDecoder from osfile.jsm

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Andrew McCreight [:mccr8]]

There are a few places in devtools that import TextEncoder and TextDecoder from osfile.jsm like this:
const {TextEncoder, OS} = Cu.import("resource://gre/modules/osfile.jsm", {});

osfile.jsm doesn't define either of them; they are just regular properties on the global. I think it would be better to add them to builtin-modules.js, akin to atob and btoa. In addition to being nicer, this will break if we start sharing globals for jsms (bug 1186409).

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92966d66cffc4ab7faeef64d2f6a279179a1de8b

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1365767 - Stop bootlegging TextEncoder and TextDecoder from osfile.jsm in devtools.

Review commit: https://reviewboard.mozilla.org/r/140752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140752/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8869117 [details]
Bug 1365767 - Stop bootlegging TextEncoder and TextDecoder from osfile.jsm in devtools.

https://reviewboard.mozilla.org/r/140752/#review144190

Thanks, looks good to me. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/756d4609d486
Stop bootlegging TextEncoder and TextDecoder from osfile.jsm in devtools. r=jryans

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/756d4609d486