1366956 - stylo: Support layout.css.prefixes.device-pixel-ratio-webkit pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

We are not currently shipping -webkit-device-pixel-ratio because of some reason, but it seems to me we want to keep the implementation and its tests so that we can enable it at some point.

Comment 1

[Manish Goregaokar [:manishearth]]

This probably could make use of the function I added to the first (now obsolete) patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1366914

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

I think we should use a static bool with observer as well. We can probably create a new class and move prefs we need there, then share them between Gecko and Stylo, so that Servo side can also access the value natively.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1366956 part 1 - Move CSS prefs from nsCSSParser into an independent class.

Review commit: https://reviewboard.mozilla.org/r/158090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158090/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1366956 part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access.

Review commit: https://reviewboard.mozilla.org/r/158092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158092/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Handle device-pixel-ratio-webkit pref correctly.

Review commit: https://reviewboard.mozilla.org/r/158094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158094/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1366956 part 3 - Update test expectations.

Review commit: https://reviewboard.mozilla.org/r/158096/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158096/

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8887291 [details]
Bug 1366956 part 1 - Move CSS prefs from nsCSSParser into an independent class.

https://reviewboard.mozilla.org/r/158090/#review163272

::: layout/style/StylePrefs.h:9
(Diff revision 1)
> +
> +namespace mozilla {
> +
> +struct StylePrefs

Nit: add a comment here saying what StylePrefs is for?

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8887292 [details]
Bug 1366956 part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access.

https://reviewboard.mozilla.org/r/158092/#review163274

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

It looks like this, as well as bug 1381690 has issue with bindgen on win32...

Comment 10

[Cameron McCormack (:heycam)]

Comment on attachment 8887294 [details]
Bug 1366956 part 3 - Update test expectations.

https://reviewboard.mozilla.org/r/158096/#review163306

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8887293 [details]
Handle device-pixel-ratio-webkit pref correctly.

https://reviewboard.mozilla.org/r/158094/#review163310

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Ok, so this is blocked on servo/rust-bindgen#822.

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

Servo side: servo/servo#17922

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8887291 [details]
Bug 1366956 part 1 - Move CSS prefs from nsCSSParser into an independent class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158090/diff/1-2/

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8887292 [details]
Bug 1366956 part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158092/diff/1-2/

Comment 16

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8887294 [details]
Bug 1366956 part 3 - Update test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158096/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba584a59aa7
part 1 - Move CSS prefs from nsCSSParser into an independent class. r=heycam
https://hg.mozilla.org/integration/autoland/rev/01dd3ada68f2
part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access. r=heycam
https://hg.mozilla.org/integration/autoland/rev/10878b3f929d
part 3 - Update test expectations. r=heycam

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3ba584a59aa7
https://hg.mozilla.org/mozilla-central/rev/01dd3ada68f2
https://hg.mozilla.org/mozilla-central/rev/10878b3f929d