1367301 - stylo: -moz-math-variant needs to override font-weight and font-style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

nsRuleNode::SetFont has:

  if (aFont->mMathVariant != NS_MATHML_MATHVARIANT_NONE) {
    // -moz-math-variant overrides font-style
    aFont->mFont.style = NS_FONT_STYLE_NORMAL;
  } else {
    // normal font-style computation
  }

and

  if (aFont->mMathVariant != NS_MATHML_MATHVARIANT_NONE) {
    // -moz-math-variant overrides font-weight
    aFont->mFont.weight = NS_FONT_WEIGHT_NORMAL;
  } else if (eCSSUnit_Enumerated == weightValue->GetUnit()) {
    // normal font-weight computation
  }

but we don't seem to have a servo equivalent.  This is causing the layout/reftests/mathml/mathvariant-3.html test failure.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I guess we either need to put -moz-math-variant in the "computed early" properties that hang off the Context via its StyleBuilder, or we need to do some sort of after-the-fact fixup, right?

Comment 2

[Manish Goregaokar [:manishearth]]

This feels like an after the fact fixup. Emilio added a framework for these

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch using early properties, just for later reference

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://github.com/servo/servo/pull/17026 will fix using fixup.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/autoland/rev/93c49ebdbc5554d2eaeaf56e6926a218b78994fe