1370727 - nsICanvasRenderingContextInternal::SetIsOpaque should return void

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Robin Steuber (she/her) [:bytesized]]

nsICanvasRenderingContextInternal::SetIsOpaque returns nsresult, but no implementations return errors. It should return void.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1370727 - Return void from nsICanvasRenderingContextInternal::SetIsOpaque

nsICanvasRenderingContextInternal::SetIsOpaque returns nsresult, but no implementations return errors. It should return void instead.

Review commit: https://reviewboard.mozilla.org/r/147712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147712/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8876274 [details]
Bug 1370727 - Return void from nsICanvasRenderingContextInternal::SetIsOpaque

https://reviewboard.mozilla.org/r/147712/#review152012

::: dom/canvas/WebGLContext.h:385
(Diff revision 1)
>                                nsIInputStream** out_stream) override;
>  
>      virtual already_AddRefed<mozilla::gfx::SourceSurface>
>      GetSurfaceSnapshot(gfxAlphaType* out_alphaType) override;
>  
> -    NS_IMETHOD SetIsOpaque(bool) override { return NS_OK; };
> +    virtual void SetIsOpaque(bool) override { return; };

Just leave the body empty.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8876274 [details]
Bug 1370727 - Return void from nsICanvasRenderingContextInternal::SetIsOpaque

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147712/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b713fb1cd98
Return void from nsICanvasRenderingContextInternal::SetIsOpaque r=bz

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5b713fb1cd98