Closed
Bug 1376961
Opened 8 years ago
Closed 8 years ago
Compartment checks do a slow TLS lookup
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
878 bytes,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
START_ASSERT_SAME_COMPARTMENT calls CurrentThreadIsHeapBusy which does an OOL call where we do a TLS lookup. Compartment checks are Nightly-only but this overhead makes it harder to profile.
Here's a patch to just inline CurrentThreadIsHeapBusy in START_ASSERT_SAME_COMPARTMENT.
Attachment #8881984 -
Flags: review?(jcoppeard)
|
||
Updated•8 years ago
|
Attachment #8881984 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e54513aa7922
Inline CurrentThreadIsHeapBusy in START_ASSERT_SAME_COMPARTMENT to avoid a TLS lookup for each compartment check. r=jonco
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•