1388531 - Remove stubbed out B2G only functions from gfx/gl/GLLibraryEGL.h

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P5)

Description

[Eric Rahm [:erahm]]

Bug 1386825 is removing MOZ_B2G and makes the stubs in gfx/gl/GLLibraryEGL.h [1] effectively dead code. We should remove them and update any callers.

[1] http://searchfox.org/mozilla-central/rev/0f16d437cce97733c6678d29982a6bcad49f817b/gfx/gl/GLLibraryEGL.h#489-514

Comment 1

[♥ Ami ♥]

Attachment: Remove stubbed out B2G only functions

Hi Jeff, I've already removed the code suggested by Eric, could you please review it? Thank you very much.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895210 [details] [diff] [review]
Remove stubbed out B2G only functions

Review of attachment 8895210 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +345,5 @@
>      // Assume that EGL has the same problem as WGL does,
>      // where MakeCurrent with an already-current context is
>      // still expensive.
>      bool hasDifferentContext = false;
> +    if (mContext) {

mContext is always truthy. Since we don't need to check this anymore, we should simplify this logic.

This should be written as:
bool needsMakeCurrent;
if (aForce) {
    needsMakeCurrent = true;
} else {
    needsMakeCurrent = (sEGLLibrary.fGetCurrentContext() != mContext);
}

if (needsMakeCurrent) {
    EGLSurface...

Comment 3

[♥ Ami ♥]

Attachment: Remove stubbed out B2G only functions

Hi Jeff, I modified the patch according to your comment, would you please review again? Thank you.

Comment 4

[♥ Ami ♥]

Hello, I don't why I cannot add the checkin-need keyword to this bug.
Can anyone help me please?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7398e1677a1
Remove stubbed out B2G only functions. r=jgilbert

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c7398e1677a1