1400762 - Deprecate dom.webcomponents.enabled and only use dom.webcomponents.customelements.enabled for Custom Elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

After we deprecate custom element v0 code, we should also deprecate/turn off  'dom.webcomponents.enabled' preference[1].

[1] http://searchfox.org/mozilla-central/rev/2c9a5993ac40ec1db8450e3e0a85702fa291b9e2/testing/profiles/prefs_general.js#68

Comment 1

[Andrew Overholt [:overholt]]

We could use dom.customelements.enabled if we wanted to be less verbose :)

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hey John, not sure I got it - per your comment "deprecate/turn off  'dom.webcomponents.enabled'" then what's the difference b/w this bug and bug 1398981 comment 7? Are these two duplicates?

Comment 3

[John Dai[:jdai]]

It is because for bug 1398981, we still have custom element v0 code in our code base, we can turn off 'dom.webcomponents.enabled' preference in that bug. However, in this bug, we suppose land all of custom element v1 code in our code base, we should deprecate/remove 'dom.webcomponents.enabled' preference once for all.

Comment 4

[Edgar Chen [:edgar] (OOO)]

In this bug, we are not going to remove dom.webcomponents.enabled pref, but just make it doesn't control CustomElements feature.

Comment 5

[Edgar Chen [:edgar] (OOO)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6be18d75fe5ebd2750e7445c667b4f02de44604&group_state=expanded&filter-tier=1

Comment 6

[Edgar Chen [:edgar] (OOO)]

Attachment: Bug 1400762 - Make dom.webcomponents.enabled pref doesn't control CustomElements feature;

CustomElements feature now is only controlled by dom.webcomponents.customelements.enabled pref.

Review commit: https://reviewboard.mozilla.org/r/199722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199722/

Comment 7

[John Dai[:jdai]]

Comment on attachment 8928469 [details]
Bug 1400762 - Make dom.webcomponents.enabled pref doesn't control CustomElements feature;

Looks good to me.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8928469 [details]
Bug 1400762 - Make dom.webcomponents.enabled pref doesn't control CustomElements feature;

https://reviewboard.mozilla.org/r/199722/#review205410

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54321e8fe928
Make dom.webcomponents.enabled pref doesn't control CustomElements feature; r=smaug

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/54321e8fe928