1414338 - Crash in TraceDataRelocations

Status: RESOLVED WORKSFORME

(Core :: JavaScript: GC, defect, P5)

Description

[Asif Youssuff]

This bug was filed from the Socorro interface and is 
report bp-ef88babf-4a3b-4023-b637-afc901171028.
=============================================================

Low volume crash; 40 crashes in the last week.

Comment 1

[Jason Orendorff [:jorendorff]]

Jon, is this actionable?

Comment 2

[u279076]

Reports over the last week:
>     Firefox 58.0a1:    16
>     Firefox 57.0b*:     6
>     Firefox 56.0.*:    29
> Firefox ESR 52.4.*:     1

Reports over the last month:
>     Firefox 58.0a1:    19
>     Firefox 57.0b*:    30
>     Firefox 56.0.*:    92
> Firefox ESR 52.4.*:     6

At these volumes I don't think this will be fixed for Firefox 56/57.

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Jason Orendorff [:jorendorff] from comment #1)
There's nothing obviously wrong with this code so this is not actionable without STR.

CC'ing Jan because it's JIT related.

Comment 4

[Jon Coppeard (:jonco)]

Attachment: bug1414338-data-reloc-assertions

Having said that, we could add some assertions here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b3fdb4f8f36
Add some assertions to TraceDataRelocations r=sfink

Comment 6

[Jon Coppeard (:jonco)]

This call to TraceDataRelocations() doesn't seem to be hit at all in our tests:

  https://searchfox.org/mozilla-central/source/js/src/jit/x86-shared/Assembler-x86-shared.cpp#94

But then again that path doesn't appear in any of the crash stacks either.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b3fdb4f8f36

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jonco, maybe it's time to close this bug?

Comment 9

[Jon Coppeard (:jonco)]

This is another ongoing crash during marking.  It's still happening but is not actionable as such.  Marking as stalled.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jonco, maybe it's time to close this bug?

Comment 11

[Jon Coppeard (:jonco)]

There's only a handful of crashes under this signature now. Closing.