Closed
      
        Bug 1415882
      
      
        Opened 7 years ago
          Closed 7 years ago
      
        
    
  
Update test262
Categories
(Core :: JavaScript Engine, enhancement, P3)
        Core
          
        
        
      
        
    
        JavaScript Engine
          
        
        
      
        
    Tracking
()
        RESOLVED
        FIXED
        
    
  
        
            mozilla59
        
    
  
People
(Reporter: evilpies, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
| 1.22 KB,
          patch         | evilpies
:
              
              review+ | Details | Diff | Splinter Review | 
| 1.23 MB,
          patch         | evilpies
:
              
              review+ | Details | Diff | Splinter Review | 
| 5.89 KB,
          patch         | evilpies
:
              
              review+ | Details | Diff | Splinter Review | 
There already a few Promise.prototype.finally test updates that I want, but also a lot of other changes.
| Reporter | ||
| Comment 1•7 years ago
           | ||
With bug 1380881 landed we should be able optional-catch-binding from UNSUPPORTED_FEATURES.
| Assignee | ||
| Comment 2•7 years ago
           | ||
And the hourCycle test [1] can also be enabled (bug 1386146).
[1] https://searchfox.org/mozilla-central/rev/30ead7d1ae5bf95b8bc0fd67b950cd46ca05e32c/js/src/tests/jstests.list#447-448
|   | ||
| Updated•7 years ago
           | 
| Assignee | ||
| Comment 3•7 years ago
           | ||
Updates the list of unsupported features in the update script.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
        Attachment #8935797 -
        Flags: review?(evilpies)
| Assignee | ||
| Comment 4•7 years ago
           | ||
Updates to latest test262.
        Attachment #8935799 -
        Flags: review?(evilpies)
| Assignee | ||
| Comment 5•7 years ago
           | ||
Updates the test262 exclusion list.
        Attachment #8935800 -
        Flags: review?(evilpies)
| Reporter | ||
| Updated•7 years ago
           | 
        Attachment #8935797 -
        Flags: review?(evilpies) → review+
| Reporter | ||
| Comment 6•7 years ago
           | ||
Why are we missing https://github.com/tc39/test262/commit/4b4c44cb51e5e89bbc22a0d1d000f49beb57b081#diff-94bd004454c40cb34eee7d1d05ee25c8? Actually finally/species-symbol.js seems to missing even before.
| Assignee | ||
| Comment 7•7 years ago
           | ||
(In reply to Tom Schuster [:evilpie] from comment #6)
> Why are we missing
> https://github.com/tc39/test262/commit/
> 4b4c44cb51e5e89bbc22a0d1d000f49beb57b081#diff-
> 94bd004454c40cb34eee7d1d05ee25c8? Actually finally/species-symbol.js seems
> to missing even before.
No sure I understand your question. The last test262 update was from the test262 version at October 23 and the Promise-finally species tests were added October 28.
| Reporter | ||
| Comment 8•7 years ago
           | ||
Comment on attachment 8935799 [details] [diff] [review]
bug1415882-part2-import-files.patch
Sorry, I totally looked for "finally" and not species-constructor.js
        Attachment #8935799 -
        Flags: review?(evilpies) → review+
| Reporter | ||
| Updated•7 years ago
           | 
        Attachment #8935800 -
        Flags: review?(evilpies) → review+
| Assignee | ||
| Comment 9•7 years ago
           | ||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc8b63de27f99cf58591cb6451eed3240f8c19ea
Keywords: checkin-needed
| Comment 10•7 years ago
           | ||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cbc25b0b6c9
Part 1: Update test262 unsupported features list. r=evilpie
https://hg.mozilla.org/integration/mozilla-inbound/rev/db63c2cb34f4
Part 2: Update test262 test files. rs=evilpie
https://hg.mozilla.org/integration/mozilla-inbound/rev/61837d2b24d4
Part 3: Update test262 exclusion list. r=evilpie
Keywords: checkin-needed
|   | ||
| Comment 11•7 years ago
           | ||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6cbc25b0b6c9
https://hg.mozilla.org/mozilla-central/rev/db63c2cb34f4
https://hg.mozilla.org/mozilla-central/rev/61837d2b24d4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
          status-firefox59:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
| Updated•7 years ago
           | 
|   | ||
| Updated•7 years ago
           | 
Flags: needinfo?(jorendorff)
          You need to log in
          before you can comment on or make changes to this bug.
        
Description
•