1416646 - GMPChild::GetUTF8LibPath returns false in some machines.

Status: NEW

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[James Cheng[:JamesCheng]]

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Agmp%3A%3AGMPChild%3A%3AProcessingError&date=%3E%3D2017-11-06T14%3A23%3A53.000Z&date=%3C2017-11-13T14%3A23%3A53.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

indicated that lots of crash issues came from 

GetUTF8LibPath(libPath)[1] returned false

[1]
https://searchfox.org/mozilla-central/rev/fe75164c55321e011d9d13b6d05c1e00d0a640be/dom/media/gmp/GMPChild.cpp#549


Bug 1184333 may be related... we still need to figure out the root cause why it still happened.

Comment 1

[James Cheng[:JamesCheng]]

Crash reports 

https://crash-stats.mozilla.com/signature/?build_id=20171110100139&product=Firefox&release_channel=nightly&platform=Windows&signature=mozilla%3A%3Agmp%3A%3AGMPChild%3A%3AProcessingError&date=%3E%3D2017-11-10T19%3A00%3A00.000Z&date=%3C2017-11-13T20%3A05%3A34.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

The url in Comment 0 is incorrect.

Comment 2

[James Cheng[:JamesCheng]]

In GMPChild::GetUTF8LibPath,
"GetPluginFile" always returns "true"

https://searchfox.org/mozilla-central/rev/fe75164c55321e011d9d13b6d05c1e00d0a640be/dom/media/gmp/GMPChild.cpp#331

So the return false must come from 

"if (!FileExists(libFile)) "

https://searchfox.org/mozilla-central/rev/fe75164c55321e011d9d13b6d05c1e00d0a640be/dom/media/gmp/GMPChild.cpp#335

Comment 3

[James Cheng[:JamesCheng]]

If the widevine CDM has been removed by any other application(such as Antivirus) or user manually do that(rarely), that means "if (!FileExists(libFile))"  will always enter.

I have no idea about other cases if the library exists on the disk, why would we check it but determine its not exist...

Maybe it's the problem with the non-latin characters in the file path, but I cannot reproduce it.

So I think I should solve the blocking bugs first and monitor the crash report.

Comment 4

[James Cheng[:JamesCheng]]

The crash did not happen after the blocking issues landed.

Keep tracking

Comment 5

[James Cheng[:JamesCheng]]

The related crash didn't happen on crash reports from 11/28 to today...