1441022 - Rules inside the shadow root shouldn't affect shadow host.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

(Except :host rules, of course).

This causes at least testing/web-platform/tests/css/selectors/focus-within-shadow-001.html to fail.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1441022: Separate the XBL and shadow dom styling bits.

Review commit: https://reviewboard.mozilla.org/r/224994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224994/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I think the logic errors that this fixes wrt XBL invalidation may fix bug 1440640.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8956051 [details]
Bug 1441022: Separate the XBL and shadow dom styling bits.

https://reviewboard.mozilla.org/r/224994/#review231508

r=me with the nit addressed.

::: servo/components/style/dom.rs:334
(Diff revision 1)
> +    /// Get the shadow host that hosts this ShadowRoot.
> +    fn style_data<'a>(&self) -> &'a CascadeData

"Get the style data of the shadow root." I suppose? It is not clear to me what is the best wording here, but the doc doesn't seem to be correct anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb1b51dfde21
Update test expectations. r=xidorn

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/eb1b51dfde21