1472366 - Remove dangling listeners in ToolboxTabs

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1472366 - Remove listeners in ToolboxTabs on unmount. r=mantaroh

ToolboxTabs can leave some listeners still bound after unmount leading to errors
during test runs.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Review in Phabricator; sending need info in case you were unaware.

Comment 3

[Phabricator Automation]

Comment on attachment 8988947 [details]
Bug 1472366 - Remove listeners in ToolboxTabs on unmount. r=mantaroh

Mantaroh Yoshinaga[:mantaroh] has approved the revision.

https://phabricator.services.mozilla.com/D1892

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Review in Phabricator; sending need info in case you were unaware.

Sorry, I didn't notice this fabricator's request.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e73482e3d3093feb8ffc9f951382290190719c6e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/984abfb799a1
Remove listeners in ToolboxTabs on unmount. r=mantaroh

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/984abfb799a1