1473796 - Add helper classes to emit bytecode for function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

Just like others (bug 1456006, bug 1456404).

Emitting function consists of two parts:
  1. emitting function declaration/expression on the parent script
  2. emitting parameters/body in the child script

To reuse the classes in BinAST streaming compilation which uses different compiler than current BytecodeEmitter which does "ParseNode=>bytecode",
those 2 parts should be separated into 2 classes.

Comment 1

[Tooru Fujisawa [:arai]]

bug 1475458 needs to be addressed, in order to design the interface.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1473796 - Part 1: Add DefaultEmitter. r?jorendorff

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1473796 - Part 2: Do not use TokenPos in BytecodeEmitter::{setFunctionBodyEndPos,setScriptStartOffsetIfUnset}. r?jorendorff

Depends on D19619

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1473796 - Part 3: Move DestructuringFlavor into its own header. r?jorendorff

Depends on D19620

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1473796 - Part 4: Add FunctionEmitter, FunctionScriptEmitter, and FunctionParamsEmitter. r?jorendorff

Depends on D19621

Comment 6

[Tooru Fujisawa [:arai]]

bug 1530324 removes wrapper for async, and also modifies the async body.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f53c8cedef75
Part 1: Add DefaultEmitter. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/d20d700c80d5
Part 2: Do not use TokenPos in BytecodeEmitter::{setFunctionBodyEndPos,setScriptStartOffsetIfUnset}. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/7e1e3f35d7cf
Part 3: Move DestructuringFlavor into its own header. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/2429f6898afa
Part 4: Add FunctionEmitter, FunctionScriptEmitter, and FunctionParamsEmitter. r=jorendorff

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f53c8cedef75
https://hg.mozilla.org/mozilla-central/rev/d20d700c80d5
https://hg.mozilla.org/mozilla-central/rev/7e1e3f35d7cf
https://hg.mozilla.org/mozilla-central/rev/2429f6898afa