1476235 - Instrument "Open in Debugger" for custom elements

Status: VERIFIED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Julian Descottes [:jdescottes]]

+++ This bug was initially created as a clone of Bug #1443923 +++

We should add telemetry probes to check the usage of this feature.

Comment 1

[:Harald Kirschner :digitarald]

Since we should hook this into event telemetry (vs landing some counter), my recommendation would be to use the "reason" property on the debugger open event.

Comment 2

[Belén [:ladybenko]]

Harald, Tim, do we have the URL of the panel that these probes go to? So we can check that the data is actually being sent. Thanks!

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Events should be visible immediately in an "Events" tab on about:telemetry (after refreshing), and they're periodically sent off to the usual incoming telemetry endpoint; does that answer your question?

Comment 4

[Belén [:ladybenko]]

Attachment: Bug 1476235 - Add telemetry for opening a custom element definition in the debugger. r=jdescottes

Comment 5

[Belén [:ladybenko]]

Attachment: Telemetry data

Comment 6

[Belén [:ladybenko]]

Hi! Tim, thanks for the heads up with `about:telemetry`, that was exactly what I needed :)

Harald, I've attached a screenshot with the data that gets sent. Is the event OK? I created a new keyword `show_custom_element` and Exit and Enter events are triggered. It works with both clicking on the "custom…" badge, and within the right-click menu. Thanks!

Comment 7

[:Harald Kirschner :digitarald]

Looks great, Belén. Thanks for looping me in early in the review!

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8998134 [details]
Bug 1476235 - Add telemetry for opening a custom element definition in the debugger. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0064f1c26b4b
Add telemetry for opening a custom element definition in the debugger. r=jdescottes

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0064f1c26b4b

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 63.0a1 (2018.07.17) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 63.0b5 on Ubuntu 16.04 x64, Windows  10 x64 and Mac OS X 10.13.