1481714 - TypeError: actors is undefined: onCustomElementDefined

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Even though we make sure we always have a registry map, we might send an element-defined event with a null actors argument. 

This results in an error in the listener defined in walker.js:
https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/devtools/server/actors/inspector/walker.js#357-361

The reason for this is that the event we added on platform side gets fired whether or not we have seen elements with a given name. This was not the case with the temporary implementation I used to do most of the development.

I think we should still fire the event, but with an empty Set(). On top of that, I think we should also emit the name of the custom element that was defined.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1481714 - Fix actors is null error when custom element is defined;r=ladybenko

Comment 2

[Belén [:ladybenko]]

Comment on attachment 8998432 [details]
Bug 1481714 - Fix actors is null error when custom element is defined;r=ladybenko

Belén [:ladybenko] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18573457af6a
Fix actors is null error when custom element is defined;r=ladybenko

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/18573457af6a