1482090 - Debugger API is always accessed via cross compartment wrappers

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

While looking at profiles from bug 1479813, I realized that Debugger API is always accessed via a cross compartment wrapper.

I don't know yet if it is because of this code:
https://searchfox.org/mozilla-central/source/devtools/shared/builtin-modules.js#223-234

Or this one:
https://searchfox.org/mozilla-central/source/js/ductwork/debugger/jsdebugger.jsm#22-25

But we should ensure that the Debugger is rooted to the same global than the modules use. That, to prevent having cross compartment wrapper when calling any API from Debugger object.


When I fix that, DAMP report substantial speedups around the debugger:
  https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=a72dc99209ce1a57f5b5ab614fc0330e7a733b53&newProject=try&newRevision=bcda5bbee34b6875ba7134cc957255f9d4a6b5d6&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1482090 - Instanciate Debugger API in the same global as DevTools modules. r=jdescottes

MozReview-Commit-ID: LS6t5CFSVom

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: D3006

Comment 3

[Alexandre Poirot [:ochameau]]

try run:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed1e74cfffb6ee215948d3f59cd19c64d7067cf7
DAMP:
  https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=a72dc99209ce1a57f5b5ab614fc0330e7a733b53&newProject=try&newRevision=ed1e74cfffb6ee215948d3f59cd19c64d7067cf7&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8998816 [details]
Bug 1482090 - Instanciate Debugger API in the same global as DevTools modules. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7941dfa029a
Instanciate Debugger API in the same global as DevTools modules. r=jdescottes

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b7941dfa029a