1487591 - Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

AccessibleCaretEventHub is an nsISelectionListener of Selection whose type is "normal". This is added only when nsFrameSelection::Init() is called and accessible caret is enabled. Additionally, nsFrameSelection::Init() is always called immediately after creating nsFrameSelection.

Therefore, when AccessibleCaretEventHub is installed to Selection, this is always second selection listener and won't be installed multiple times. So, Selection can store pointer of AccessibleCaretEventHub only when it's enabled and the Selection needs to notify it of selection change.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Bug 1487591 - Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener

AccessibleCaretEventHub is an nsISelectionListener of Selection whose type is
"normal".  This is added only when nsFrameSelection::Init() is called and
accessible caret is enabled.  Additionally, nsFrameSelection::Init() is
always called immediately after creating nsFrameSelection.

Therefore, when AccessibleCaretEventHub is installed to Selection, this is
always second selection listener and won't be installed multiple times.  So,
Selection can store pointer of AccessibleCaretEventHub directly only when
it's enabled and the Selection needs to notify it of selection change.

This patch makes Selection stores AccessibleCaretEventHub with RefPtr and
make it in cycle collection, then, makes Selection::NotifySelectionListeners()
call its OnSelectionChange() immediately after AutoCopyListener.

Unfortunately, this patch includes making of MOZ_CAN_RUN_SCRIPT_BOUNDARY and
MOZ_CAN_RUN_SCRIPT a lot since some methods of AccessibleCaretEventHub are
marked as MOZ_CAN_RUN_SCRIPT and including AccessibleCaretEventHub.h into
Selection.h causes compile the compile errors.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a65f3164b7001be7815a9c0ccad71b3f74462378

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9005541 [details]
Bug 1487591 - Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener

Olli Pettay [:smaug] has approved the revision.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e17823b94473630945cec64fdacae15ef4e683b8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdbd39b2251d
Make Selection treat AccessibleCaretEventHub as concrete class rather than nsISelectionListener r=smaug

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bdbd39b2251d