1529002 - Eclipse demo spends 30-40ms styling 300 elements (transform list conversion from rust to C++)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Mayank Bansal]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. enable WR, picture caching
2. Go to http://themaninblue.com/experiment/eclipse/
3. Move the mouse around

Actual results:

animation is smooth. However, the gecko profiler shows quite a lot of time spent in styling.

https://perfht.ml/2SdP9S6 (with parallel styling disabled)

Expected results:

not so?
I am not sure how real world this is, or if the time spent is expected.
Feel free to RESOLVED INVALID this bug.

Comment 1

[Mayank Bansal]

Attachment: aboutsupport.txt

Comment 2

[Mayank Bansal]

Emilio, WDYT?

(WR and picture caching are enabled because without WR, demo is super slow, and all the time is spent in gfx stuff)

Comment 3

[Mayank Bansal]

and this is profile with parallel styling : https://perfht.ml/2ScGq2z

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Ugh, most of the time is spent in malloc() / free(), which is unfortunate.

I think this is not too terrible, but all the work I'm doing to switch us to not having to convert from the rust representation to the C++ representation should help quite a bit here.

Unfortunately transform is one of the toughest ones to crack though :)

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1529002 - Use cbindgen to back CSS transforms. r=boris

This avoid the expensive conversion, and cleans up a bunch.

Further cleanup is possible, just not done yet to avoid growing the patch even
more.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1529002 - Update cbindgen. r=boris

We need this to auto-generate the copy-constructor for TransformOperation,
without which the patch wouldn't build.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

\o/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6798155e71dc
Update cbindgen. r=boris
https://hg.mozilla.org/integration/autoland/rev/35f91a9ea82a
Use cbindgen to back CSS transforms. r=boris

Comment 9

[Andrei Ciure[:aciure]]

Backed out 17 changesets (bug 1550554, bug 1549593, bug 1551991, bug 1529002) for failing multiple Android tests and Windows 2012 bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=35f91a9ea82af8ba15ea08996149bb871d6957f8

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246819809&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-geckoview-junit-e10s-1%2C%28gv-junit1%29

win2012 bustages: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246815110&searchStr=windows%2C2012%2Caarch64%2Cdebug%2Cbuild-win64-aarch64%2Fdebug%2C%28b%29

backout: https://hg.mozilla.org/integration/autoland/rev/283b94c196a15367f287fd7f2bb6c9b4bcad0b45

Comment 10

[Alexandru Michis [:malexandru]]

New failure "Assertion failure: _0.ptr->data.header.header == kArcSliceCanary (Uh?), at z:/build/build/src/obj-firefox/dist/include\mozilla/ServoStyleConstsInlines.h:118"

Failure link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246826943&repo=autoland&lineNumber=993

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Yeah, see bug 1550554 comment 11 for the explanation. Same mistake.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29c5fc63a9bf
Update cbindgen. r=boris
https://hg.mozilla.org/integration/autoland/rev/02c806cb81d9
Use cbindgen to back CSS transforms. r=boris

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/29c5fc63a9bf
https://hg.mozilla.org/mozilla-central/rev/02c806cb81d9