1530951 - 3.58 - 3.99% sessionrestore / sessionrestore_no_auto_restore / ts_paint / ts_paint_webext (linux64-pgo-qr) regression on push 44192297e3ae55473fbe669a681f937191a54b81 (Tue Feb 26 2019)

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect, P5)

Description

[Florin Strugariu [:Bebe]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=44192297e3ae55473fbe669a681f937191a54b81

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

4% sessionrestore linux64-pgo-qr opt e10s stylo 780.67 -> 811.83
4% sessionrestore_no_auto_restore linux64-pgo-qr opt e10s stylo 828.00 -> 859.58
4% ts_paint_webext linux64-pgo-qr opt e10s stylo 843.00 -> 874.25
4% ts_paint linux64-pgo-qr opt e10s stylo 841.83 -> 872.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=19648

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Jeff Muizelaar [:jrmuizel]]

The regression only happens on linux where startup perf is currently heavily impacted by shader compilation. We don't currently cache shaders on Linux but plan to before release. Therefore, I think we can safely ignore this for now.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This is similar to bug 1527829 which we WONTFIXED

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

The regression only happens on linux where startup perf is currently heavily impacted by shader compilation. We don't currently cache shaders on Linux but plan to before release. Therefore, I think we can safely ignore this for now.

Would you consider keeping this open until this is implemented? If we WONTFIX this then there's a risk it will not be addressed. Also could you add the relevant bug as a dependency?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

What fixed this?

Comment 5

[Florin Strugariu [:Bebe]]

My mistake here. Let's reopen this...

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Bebe, not sure what flags should be set here. Could you look into this and update it accordingly? This is 2 years old.

Comment 7

[Florin Strugariu [:Bebe]]

Tracking Flags: are set and updated. nothing to do here