1533097 - Remove gfxWindowsPlatform::RecordStartupTelemetry from the content process

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Jim Mathies [:jimm]]

Calls:

NtUserGetProcessUIContextInformation, NtGdiDdDDIEnumAdapters2, NtGdiDdDDICacheHybridQueryValue

Typical stack:

24 - win32u!NtUserDisplayConfigGetDeviceInfo
win32u!NtUserDisplayConfigGetDeviceInfo
user32!DisplayConfigGetDeviceInfo+0xa
dxgi!SAdapterDesc::SAdapterDesc+0x221
dxgi!CDXGIFactory::SampleAdaptersWorker+0x1dc
dxgi!CDXGIFactory::SampleAdapters+0xcd
dxgi!CDXGIFactory::Initialize+0xbb
dxgi!CreateDXGIFactoryImpl+0x72
dxgi!CreateDXGIFactoryActualImpl1+0x32
dxgi!CreateDXGIFactory1+0x5d
xul!mozilla::gfx::DeviceManagerDx::GetDXGIAdapter+0x157
xul!mozilla::gfx::DeviceManagerDx::EnumerateOutputs+0x41
xul!gfxWindowsPlatform::RecordStartupTelemetry+0x37

Comment 1

[June Wilde (she/her) [:jewilde]]

Attachment: Bug 1533097 - restrict gfxWindowsPlatform::RecordStartupTelemetry to parent; r?jrmuizel

Adds early exit if not originating in the parent process when recording
display HDR capability. This helps to remove more win32k usage from
content processes.

Comment 2

[June Wilde (she/her) [:jewilde]]

I tagged you for review since you were the last reviewer for this function, but wanted to also double check that restricting this to the main process (which I think is what was intended in Bug 1514840) wouldn't mess up y'all's telemetry pipeline.

Let me know if this works or if you need me to change anything!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24870321bdeb
restrict gfxWindowsPlatform::RecordStartupTelemetry to parent; r=jrmuizel

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/24870321bdeb