1545763 - Picture-in-Picture does not work properly for Facebook videos in portrait mode

Status: RESOLVED WONTFIX

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Cristian Craciun]

STR:

0. Ensure media.videocontrols.picture-in-picture.enabled and media.videocontrols.picture-in-picture.video-toggle.enabled are set to true
1. Visit https://facebook.com/ and log in with a valid account
2. Scroll down until you find a video in portrait mode on your home page
3. The video starts and the toggle button is displayed
4. Click on the toggle button to open the Picture in Picture window

ER:

The Picture-in-Picture window opens in proper size and preserves the aspect ratio while the video keeps running

AR:

The page of the video is opened (the link is changed) and the PiP window opens in a smaller resolution. Also the "close" and "play/pause" buttons are duplicated.

Note:
If you can't find a video you can use this link:
https://www.facebook.com/watch/?v=326853498025559

Comment 1

[Fanolian]

Similar issues occurs on Reddit as well, e.g. https://www.reddit.com/r/aww/comments/bey4p0/i_call_this_the_pupper_plop/.

In addition, Reddit-hosted videos, i.e. v.redd.it links like the above, do not have a context menu entry for the PiP toggle.
(Counterexample: gfycat.com video on Reddit)

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi Cristian,

Can you show me a screenshot of both the original video on Facebook, as well as the PiP window after it's been opened? I want to better understand what you mean about the size, and aspect ratio.

Comment 3

[Cristian Craciun]

Attachment: pip-portrait

Hi Mike,

Yes, here is the link of the video:
https://www.facebook.com/9gag/videos/454707108602485/

And I've uploaded the attachment with the PiP window.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

In this case, the actual video is in portrait. I'm not certain if we should be attempting to reproduce the black bars on either side in cases like this. I'll split the button glitches into a separate bug.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Are you still able to reproduce this, Cristian?

Comment 6

[Fanolian]

Attachment: PiP portrait 2019-10-24

Not OP but I can still reproduce the issue of odd portrait video pop-out size.
Portrait video example: https://www.youtube.com/watch?v=KRntP-q_R9s

I do not know what the optimal size for a portrait pop-out would be, but definitely it is not this small with the height shorter than a landscape video.

The button issue was fixed in bug 1546983.

Comment 7

[Cristian Craciun]

Build ID 20191025095546
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Yes, I can still reproduce this. It's the same behavior described on youtube.com with portrait videos. Here is a valid link for a video on facebook:
https://www.facebook.com/ODKorea/videos/345016423072928/

Comment 8

[Ania]

I can't repro this on any of the vertical FB videos on MacOS Nightly 96.0a1 (2021-11-29) (64-bit). Attached a screenshot.

However, the briefly noted Reddit issue where no PiP toggle is displayed is still reproducible and affects non-Reddit hosted videos too:
https://www.reddit.com/r/videos/comments/r5o3oe/what_researching_genealogy_feels_like/
https://www.reddit.com/r/videos/comments/r5o805/florida_man_makes_beer_run_with_gator_in_hand/

Both videos work well with Chrome PiP.

This might be a known issue too, but FB video player seems to suppress PiP for the benefit of its own miniplayer, an example video here

I'll file the Reddit issue separately to avoid confusion, and unless vertical FB videos are still causing troubles, I'd be inclined to close this.

Comment 9

[Ania]

Attachment: Pip Portrat 2021-11

Comment 10

[Fanolian]

Attachment: PiP portrait brand new profile 2021-11-30 build.png

As for the issue of portrait video PiP size, I can still reproduce it in a brand new profile, i.e. never adjusted the PiP size before.

However this should be a non-issue now since Firefox remembers the size and location from the previous PiP window. Users will see such a small pop-up only once, change the size themselves, and never revert to this default small size again.

Perhaps the Firefox Support article should mention the ability to resize the PiP window though.

Comment 11

[Ania]

Thank you for checking on this, I agree this is a non-issue.
We will work with SUMO to update the article for one of the upcoming releases!