1546970 - Picture-in-Picture toggle is available for Facebook videos displayed in notifications

Status: RESOLVED WORKSFORME

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Cristian Craciun]

Attachment: pip_fb_notification.png

Steps to reproduce:

1. Visit https://facebook.com/ and log in with a valid account
2. Subscribe to different pages that post videos
3. Wait for a notification with a video to be received in the lower left side of the page
4. Click on the toggle button to open the Picture in Picture window

Expected Result:

The Picture-in-Picture toggle should not be available

Actual Result:

The Picture-in-Picture toggle is available and can be used.

Note:
The PiP window is displayed after the toggle is used. The PiP windows is small and the video stops after the notification is not displayed anymore.

Please see the attachment.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hi Cristian,

Does the video in the notification play audio at all? I wonder if that can be fed into a heuristic that we can use to determine if videos should show the toggle or not.

Comment 2

[Cristian Craciun]

Hi Mike,

In the notification the audio is not available.

Steps 2 and 3 can be reproduced easier using another test account. The second user will post a video or a live video and the notification will be displayed for the first user.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Similar problem in Facebook profile photo

I also see this in the Facebook profile photo for users who have the video-based profile photo. There doesn't appear to be any audio in the video, but I am not able to prove it.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey Cristian, with bug 1547795 closed, is this still an issue?

Comment 5

[Cristian Craciun]

Hey Mike, both issues are fixed, the PiP toggle is not displayed over the notification or the profile video-based picture.

But I've noticed that the PiP toggle is still displayed in the message chat for videos sent by private message. Could you take a look over it? Should I log another bug for this issue?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

(In reply to Cristian Craciun from comment #5)

But I've noticed that the PiP toggle is still displayed in the message chat for videos sent by private message. Could you take a look over it? Should I log another bug for this issue?

Sure, let's get that on file and we'll take a look.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Closing per comment 5.