1552081 - sometime we should only run 'TimeMarchesOn' when media element's show poster flag is false

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

In the following situations, we should only run TimeMarchesOn when the media element's show-poster flag is false.

• add cue : https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-2
• remove cue : https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-3
• track mode changes : https://html.spec.whatwg.org/multipage/media.html#text-track-model:time-marches-on
• cue's startTime changes : https://html.spec.whatwg.org/multipage/media.html#text-track-api:time-marches-on
• cue's endTime changes : https://html.spec.whatwg.org/multipage/media.html#text-track-api:time-marches-on-2

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1552081 - part1. Sometimes we should run 'TimeMarchesOn' only when the media element's show poster flag is false.

In the following situations, we should only run TimeMarchesOn when the media element's show-poster flag is false.

• add cue : https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-2
• remove cue : https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:time-marches-on-3
• track mode changes : https://html.spec.whatwg.org/multipage/media.html#text-track-model:time-marches-on
• cue's startTime changes : https://html.spec.whatwg.org/multipage/media.html#text-track-api:time-marches-on
• cue's endTime changes : https://html.spec.whatwg.org/multipage/media.html#text-track-api:time-marches-on-2

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1552081 - part2. Modify test 'test_webvtt_update_display_after_adding_or_removing_cue.html'.

Now adding or removing cue would trigger processing cues only when media element's show-poster flag is false, so we have to modify the test to reset the flag in order to test the correct behavior.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95ccc685eb11
part1. Sometimes we should run 'TimeMarchesOn' only when the media element's show poster flag is false. r=jya
https://hg.mozilla.org/integration/autoland/rev/7b72fa29c64b
part2. Modify test 'test_webvtt_update_display_after_adding_or_removing_cue.html'. r=jya

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/95ccc685eb11
https://hg.mozilla.org/mozilla-central/rev/7b72fa29c64b