1561590 - 9.88 - 12.67% Images (linux64-shippable-qr) regression on push bbc2f71bfa7f1428ef84ae5b0fdfc05957eb0735 (Wed June 12 2019)

Status: VERIFIED FIXED

(Testing :: AWSY, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

We have detected an awsy regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=bbc2f71bfa7f1428ef84ae5b0fdfc05957eb0735

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

13% Images linux64-shippable-qr opt 5,829,246.40 -> 6,568,038.08
10% Images linux64-shippable-qr opt 5,875,023.00 -> 6,455,417.00
10% Images windows10-64-shippable-qr opt 7,264,126.71 -> 7,969,779.78

Improvements:

10% Resident Memory windows10-64-shippable opt stylo tp6 712,686,249.58 -> 638,396,336.55
10% Resident Memory windows7-32-shippable opt 601,605,538.82 -> 540,611,017.71
8% Resident Memory linux64-shippable opt 632,339,972.06 -> 583,857,860.22
7% Explicit Memory linux64-shippable-qr opt 494,073,019.03 -> 457,444,874.27
7% Resident Memory windows7-32-shippable opt stylo tp6 717,704,650.80 -> 664,505,525.87
7% Resident Memory windows10-64-shippable opt 535,586,478.90 -> 497,152,221.16
6% Resident Memory linux64-shippable opt stylo tp6 789,161,460.35 -> 743,481,045.44
6% Resident Memory linux64-shippable-qr opt 787,599,117.47 -> 743,213,564.18
6% Resident Memory windows10-64-shippable-qr opt 556,240,367.05 -> 525,254,813.99
5% Resident Memory windows10-64-shippable-qr opt stylo tp6 785,553,482.31 -> 748,681,849.53
4% Resident Memory linux64-shippable-qr opt stylo tp6 914,370,365.31 -> 875,451,855.89

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21576

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/AWSY/Tests

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:alexandru.ionescu, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Sure, thanks for the note.

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

hskupin, I updated the description so it shows more close to reality data.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The change as done in Marionette will not be reverted because it is necessary right now to workaround some known bugs like not presenting a HTTP auth dialog (bug 1557457).

If AWSY needs the preference browser.tabs.remote.separatePrivilegedContentProcess set to true, we would have to add it back to its own profile settings. But this is not a decision I can make so deferring the decision to Eric, and Bob.

Comment 5

[Bob Clary [:bc] (inactive)]

/me deferring to erahm.

Comment 6

[Eric Rahm [:erahm]]

Yes, this pref should be enabled for AWSY, as we want to test as close to nightly as possible.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This. should be fixed now based on the landing of bug 1562036.

Comment 8

[Ionuț Goldan [:igoldan]]

Alexandru, could you please verify the fix?

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Ionut, the fix looks good. We can consider it done.