156301 - Link focus outline ghosting during "find next"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Aaron Leventhal]

As you find next (CtrL+G), and move through links and non-links, Mozilla doesn't
erase the old outlines of anchors that it highlighted.

To reproduce, open www.mozilla.org and search for "Gecko". Hit Ctrl+G several
times eventually you will have 2 or more focus rings on links.

The fix is exactly what Bryner caught in a review of some code I wrote before,
but we weren't sure whether it was correct back then.

Comment 1

[Aaron Leventhal]

Attachment: If we're already focused on a link in this document, and are now focusing on the document itself, use SetContentState(nsnull, NS_EVENT_STATE_FOCUS) rather than SendFocusBlur()

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 90514 [details] [diff] [review]
If we're already focused on a link in this document, and are now focusing on the document itself, use SetContentState(nsnull, NS_EVENT_STATE_FOCUS) rather than SendFocusBlur()

r=bryner

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 90514 [details] [diff] [review]
If we're already focused on a link in this document, and are now focusing on the document itself, use SetContentState(nsnull, NS_EVENT_STATE_FOCUS) rather than SendFocusBlur()

sr=jst

Comment 4

[Aaron Leventhal]

fix checked in

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381