1564170 - [jsdbg2] Debugger should use NativeObject subclasses for all Debugger.Foo API objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jim Blandy :jimb]

The Debugger implementation does not define C++ classes derived from NativeObject for all its Debugger.Foo types—for example, there is no DebuggerScript class—so that many of C++'s basic structuring tools like member functions, member types, and static data members are not available. Basic SpiderMonkey tools like the is<> and as<> methods on JSObject don't work. Definitions are simply given DebuggerScript_ prefixes. This code should be modernized.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1564170: Give Debugger.Script instances their own NativeObject subclass, DebuggerScript. r?jorendorff

Comment 2

[Jim Blandy :jimb]

Attachment: Bug 1564170: Make Debugger.Script referent variant matcher classes into member classes of DebuggerScript. r?jorendorff

Depends on D37509

Comment 3

[Jim Blandy :jimb]

Attachment: Bug 1564170: Give Debugger.Source instances their own NativeObject subclass, DebuggerSource. r?jorendorff

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c49c2a77f7
Give Debugger.Script instances their own NativeObject subclass, DebuggerScript. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/fe088addd88a
Make Debugger.Script referent variant matcher classes into member classes of DebuggerScript. r=jorendorff

Comment 5

[Jim Blandy :jimb]

Clean try push for Debugger.Source patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c3287ea6ea174e96a45f1bb185cf5fe778b7898

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/61c49c2a77f7
https://hg.mozilla.org/mozilla-central/rev/fe088addd88a

Comment 7

[Jim Blandy :jimb]

Attachment: Bug 1564170: Clean up some DebuggerScript referent matchers. r=jorendorff

As suggested in patch review, some of the mozilla::Variant matcher classes in
Script.cpp could be written more clearly using lambda-based matching. This patch
applies that technique in the implementations of DebuggerScript's create,
getStartLine, and getFormat methods.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa9803f6070
Give Debugger.Source instances their own NativeObject subclass, DebuggerSource. r=jorendorff

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5fa9803f6070

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7541e22758eb
Clean up some DebuggerScript referent matchers. r=jorendorff

Comment 11

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7541e22758ebfdbbb2514184e1bb822bff53ecee&selectedJob=265292628

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265292628&repo=autoland&lineNumber=7223

Backout: https://hg.mozilla.org/integration/autoland/rev/221a89193a200500d80441f7f32f38912c639f60

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e68e94c2d26
Clean up some DebuggerScript referent matchers. r=jorendorff

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4e68e94c2d26