1567633 - High-frequency messages cause multi-second hangs

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[:Harald Kirschner :digitarald]

STR:

• Open https://puzzling-rake.glitch.me/ (http://tankanarchy.herokuapp.com/ for a game that sends even more)
• Observe WebSocket messages

AR:
The UI freezes for multiple seconds while messages are rendered in chunks.

Bug 1561631 might help with this somewhat, but only if the bottleneck is the amount of elements; which might not be the case.

Profile: https://perfht.ml/2YgfAh8 (tankanarchy: https://perfht.ml/2Ybjnwd)

• React's diffProperties$1 is high, so switching some classes to pure components or using shouldComponentUpdate might reduce overhead.
• setState takes the biggest chunk of time, so debouncing onFrameReceived (maybe using requestIdleCallback) might also free some main thread and bundle table updates.

Comment 1

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1567633 - High-frequency messages cause multi-second hangs. r=Honza

Triggers addFrames in batches

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/225f4a11bbb1
High-frequency messages cause multi-second hangs. r=Honza

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/225f4a11bbb1