1570207 - Move CanAccess logic from DocShell to BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Kris Maglione [:kmag]]

BrowsingContext::CanAccess currently defers to nsDocShell to determine whether one BrowsingContext can navigate another. This means that it only works for in-process DocShells, and crashes when used with OOP contexts.

The existing DocShell logic is also much more complicated than it needs to be, given the current architecture. It was written in a time before named targetting was restricted to a single TabGroup/BrowsingContextGroup, which makes most of its remaining OriginAttributes and private browsing checks completely unnecessary.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1570207: Part 1 - Move CanAccess logic from DocShell to BrowsingContext. r=nika

This change is necessary in order to support named targeting of remote
BrowsingContexts, since the current arrangement only supports in-process
contexts. It also considerably simplifies the logic, since named targetting is
now restricted to the same TabGroup/BrowsingContextGroup, which in and of
itself guarantees that origin attributes will always match in the cases that
we care about.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1570207: Part 2 - Remove skip-if/fail-if annotations for CanAccessItem failures. r=nika

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfc8b1c626dcf3cf146fafc606fbe0cf8064d1a
Bug 1570207: Part 1 - Move CanAccess logic from DocShell to BrowsingContext. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/783c0e44c713d31bdf14dd84bdded192171343d1
Bug 1570207: Part 2 - Remove skip-if/fail-if annotations for CanAccessItem failures. r=nika

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7bfc8b1c626d
https://hg.mozilla.org/mozilla-central/rev/783c0e44c713

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1570207: Follow-up: Update failure annotations. r=nika

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bfe96677cf3
Follow-up: Update failure annotations. r=mccr8

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5bfe96677cf3