1572280 - Reparse sources with GC'ed scripts when getting breakpoint positions

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Brian Hackett [Laid off!]]

Breakpoint positions for a source should reflect all places where breakpoints can be set in the source, but if scripts have been GC'ed then the positions returned by the server will be incomplete, preventing users from being able to set breakpoints within them, a pretty confusing behavior. We have the text for the source, so it can just be reparsed to figure out where the breakpoint positions are. For efficiency, it seems best to do this only when we know that scripts in the source might have been GC'ed. I'm reasonably sure that sources can contain at most one non-function script, which will the top level script and will hold all other scripts in the source alive. So, if we are able to find this script, we know that there aren't any missing breakpoint positions and can avoid reparsing.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1572280 Part 1 - Add Debugger.Source.reparse(), r=jimb.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1572280 Part 2 - Add Debugger.Script.isFunction, r=jimb.

Depends on D41126

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1572280 Part 3 - Reparse sources with GC'ed scripts to get all breakpoint positions, r=loganfsmyth.

Depends on D41127

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc14494262b1
Part 1 - Add Debugger.Source.reparse(), r=jimb.
https://hg.mozilla.org/integration/autoland/rev/1c11235a668a
Part 2 - Add Debugger.Script.isFunction, r=jimb.
https://hg.mozilla.org/integration/autoland/rev/efe4a620841c
Part 3 - Reparse sources with GC'ed scripts to get all breakpoint positions, r=loganfsmyth.

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bc14494262b1
https://hg.mozilla.org/mozilla-central/rev/1c11235a668a
https://hg.mozilla.org/mozilla-central/rev/efe4a620841c