Closed Bug 1573803 Opened 6 years ago Closed 6 years ago

Argument 1 passed to HarbormasterBuildPlanBehavior::getPlanOption() must be an instance of HarbormasterBuildPlan, null given

Categories

(Conduit :: Phabricator, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: anba, Unassigned)

Details

All change sets in bug 1129202 report the following Phabricator error:

[Core Exception/TypeError] Argument 1 passed to HarbormasterBuildPlanBehavior::getPlanOption() must be an instance of HarbormasterBuildPlan, null given, called in /app/phabricator/src/applications/differential/storage/DifferentialRevision.php on line 881

Not sure if that's the cause of the error, but in case it's helpful to know: I've uploaded the changes with moz-phab submit --wip and no author, and later resubmitted them with the author added (and no --wip).

(In reply to André Bargull [:anba] from comment #0)

Not sure if that's the cause of the error, but in case it's helpful to know: I've uploaded the changes with moz-phab submit --wip and no author, and later resubmitted them with the author added (and no --wip).

Hmm, that could be the cause of this error, because I did the same in bug 1188079 and I'm getting the same Phabricator error for the change sets of that bug.

Could you please check if this is still happening after moz-phab self-update?
Is the bug displayed in moz-phab or Phabricator?
If it is in moz-phab, please provide the logs stored in /.mozbuild/moz-phab/moz-phab.log

Flags: needinfo?(andrebargull)

It's (In reply to Piotr Zalewa [:zalun] from comment #2)

Could you please check if this is still happening after moz-phab self-update?

Do you want me to re-run moz-phab submit after the update, too? (I didn't try to tinker with the apparently broken uploads to make sure the error is still displayed when this bug gets investigated.)

Is the bug displayed in moz-phab or Phabricator?

It's in Phabricator itself → e.g. https://phabricator.services.mozilla.com/D39034 displays that error message.

Flags: needinfo?(andrebargull)

We've tried to figure out what happened here, but unfortunately we've been unable to reproduce the issue following the steps you outlined, nor do we have any theories which hold water that explain the outcomes.

Closing as WORKSFORME, don't hesitate to reopen if the issue reoccurs.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.