1574480 - browser.js PermissionManager calls should use principals

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[Emma Zühlcke [:emz]]

We would like to remove permission manager calls with nsIURI in bug 1402957.

PermissionManager usages with nsIURI: https://searchfox.org/mozilla-central/rev/3a61fb322f74a0396878468e50e4f4e97e369825/browser/base/content/browser.js#3757,7969,8004,8082,8086

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1574480 - Updated browser.js and OfflineAppsChild.jsm to use PermissionManager principal methods. r=johannh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2867a062f45
Updated browser.js and OfflineAppsChild.jsm to use PermissionManager principal methods. r=johannh,smaug

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backed out changeset d2867a062f45 (bug 1574480) for browser-chrome failures at browser/base/content/test/general/browser_offlineQuotaNotification.js

Backout: https://hg.mozilla.org/integration/autoland/rev/d1af59ad37027ddb218efe63e139e10db18eed9d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d2867a062f4582019b7edea6828fb9b849a5a8ff&selectedJob=265157995

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265156081&repo=autoland&lineNumber=9325

[task 2019-09-05T15:03:20.788Z] 15:03:20 INFO - GECKO(1711) | --DOMWINDOW == 13 (0x164230c00) [pid = 1711] [serial = 479] [outer = 0x0] [url = about:blank]
[task 2019-09-05T15:03:20.788Z] 15:03:20 INFO - GECKO(1711) | --DOMWINDOW == 12 (0x171662800) [pid = 1711] [serial = 415] [outer = 0x0] [url = about:blank]
[task 2019-09-05T15:04:34.123Z] 15:04:34 INFO - TEST-INFO | started process screencapture
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - Buffered messages logged at 15:03:04
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - Loaded page, adding onCached handler
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - Buffered messages finished
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_offlineQuotaNotification.js | Test timed out -
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - GECKO(1711) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 112}]
[task 2019-09-05T15:04:34.260Z] 15:04:34 INFO - GECKO(1711) | MEMORY STAT | vsize 8252MB | residentFast 872MB | heapAllocated 137MB

Comment 5

[Jonathan Kingston [:jkt] he/him]

:pbz as a heads up I discussed this with :johannh and we agreed to disable the two tests modified in this patch as we are aiming to remove appcache in it's entirety https://bugzilla.mozilla.org/show_bug.cgi?id=1237782 and I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1579444 to remove all the quota code.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fedd8400ab2
Updated browser.js and OfflineAppsChild.jsm to use PermissionManager principal methods. r=johannh,smaug

Comment 7

[Emma Zühlcke [:emz]]

(In reply to Jonathan Kingston [:jkt] from comment #5)

:pbz as a heads up I discussed this with :johannh and we agreed to disable the two tests modified in this patch as we are aiming to remove appcache in it's entirety https://bugzilla.mozilla.org/show_bug.cgi?id=1237782 and I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1579444 to remove all the quota code.

Thanks! I've also disabled the tests in my patch.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9fedd8400ab2