1583882 - Picture-in-Picture player window should close if the associated <video> is removed from the DOM

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Just as it says on the tin.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1583882 - Remove vestigial TogglePictureInPicture privileged method on HTMLVideoElement. r=dminor!,#webidl*

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1583882 - Fire an event when a <video> being visually cloned is removed from the DOM. r?dminor

Depends on D47611

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1583882 - Close Picture-in-Picture player window if the originating <video> is removed from the DOM. r?JSON_Voorhees

Depends on D47612

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1583882 - Regression test. r?JSON_Voorhees

Depends on D47613

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f219d86f132e
Remove vestigial TogglePictureInPicture privileged method on HTMLVideoElement. r=webidl,dminor,smaug*
https://hg.mozilla.org/integration/autoland/rev/ab530e0ca195
Fire an event when a <video> being visually cloned is removed from the DOM. r=dminor
https://hg.mozilla.org/integration/autoland/rev/6b4844ef3b2b
Close Picture-in-Picture player window if the originating <video> is removed from the DOM. r=JSON_voorhees
https://hg.mozilla.org/integration/autoland/rev/43c79d7f6b64
Regression test. r=JSON_voorhees

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f219d86f132e
https://hg.mozilla.org/mozilla-central/rev/ab530e0ca195
https://hg.mozilla.org/mozilla-central/rev/6b4844ef3b2b
https://hg.mozilla.org/mozilla-central/rev/43c79d7f6b64

Comment 8

[Cristian Craciun]

Build ID 20191022214314
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest Nightly build on Windows 10.