1670886 - [wpt-sync] Sync PR 26087 - [:is/:where] Support :is/:where inside :not

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26087 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26087
Details from upstream follow.

b'Anders Hartvoll Ruud <[e-mail]>' wrote:

[:is/:where] Support :is/:where inside :not

This adds support for using :is inside :not, without expanding the
capabilities of :not itself. (In other words, we still only accept
a single simple selector when using non-nesting selectors directly
within :not).

For invalidation, we do need to traverse into the complex selectors
nested (deep) inside :not(), for example to mark .b as invalidates-
self for ".a :not(:is(.b))", but at the :not-boundary during feature
extraction, we avoid propagating the features, such that .a is marked
with whole-subtree recalc. We already have similar logic in
ExtractInvalidationSetFeaturesFromCompound which prevents feature
extraction for selectors held by :not directly.

Note that CSSParserSelector::IsSimple() only has one call-site, and
that's during parsing of :not().

Bug: 568705
Change-Id: Ic7cb421c4d8f6a6e85cfea30c987db2e0fed64fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463830
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#816328}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e1e0d6f2046d7f047af02b5620179a3fd13f533

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 14 subtests

Status Summary

Firefox

OK : 2
PASS: 30
FAIL: 2

Chrome

OK : 2
PASS: 10
FAIL: 22

Safari

OK : 2
PASS: 30
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/selectors/is-where-not.html
:not(:is(div > :not(#e))) matches expected elements: FAIL (Chrome: FAIL, Safari: PASS)
:not(:is(div > :not(:where(#e, #f)))) matches expected elements: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 14 subtests

Status Summary

Firefox

OK : 2
PASS: 30
FAIL: 2

Chrome

OK : 2
PASS: 10
FAIL: 22

Safari

OK : 2
PASS: 30
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/selectors/is-where-not.html
:not(:is(div > :not(#e))) matches expected elements: FAIL (Chrome: FAIL, Safari: PASS)
:not(:is(div > :not(:where(#e, #f)))) matches expected elements: FAIL (Chrome: FAIL, Safari: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b456cf4cbe1
[wpt PR 26087] - [:is/:where] Support :is/:where inside :not, a=testonly
https://hg.mozilla.org/integration/autoland/rev/38abc3338cf8
[wpt PR 26087] - Update wpt metadata, a=testonly

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8b456cf4cbe1
https://hg.mozilla.org/mozilla-central/rev/38abc3338cf8