1671538 - return rejected decodeAudioData() promise when not fully active

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement)

Description

[Karl Tomlinson (:karlt)]

See https://github.com/WebAudio/web-audio-api/pull/2210/files

Comment 1

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d2c03e0287ce72752b5bdb3fda616bb5819d4c3

Comment 2

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=206d55992661ba2ffb57a1268c929a61a21ad3fb

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1671538 make audit task wait for decodeAudioData() promise to settle r?padenot

Previously audit would wait for the async function to complete,
but the function did not await the promise.

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1671538 expect InvalidStateError for decodeAudioData() in inactive document r?padenot

https://github.com/WebAudio/web-audio-api/issues/2176

Depends on D94217

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1671538 return rejected promise from promise-returning methods when not fully active r?padenot

Depends on D94218

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1671538 test for rejected promises from methods on an AudioContext in a discarded browsing context r?padenot

Depends on D94219

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cbed1201a5d
make audit task wait for decodeAudioData() promise to settle r=padenot
https://hg.mozilla.org/integration/autoland/rev/3d61224818fe
expect InvalidStateError for decodeAudioData() in inactive document r=padenot
https://hg.mozilla.org/integration/autoland/rev/8e79ee468e48
return rejected promise from promise-returning methods when not fully active r=padenot
https://hg.mozilla.org/integration/autoland/rev/c69f68084e04
test for rejected promises from methods on an AudioContext in a discarded browsing context r=padenot

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26243 for changes under testing/web-platform/tests

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4cbed1201a5d
https://hg.mozilla.org/mozilla-central/rev/3d61224818fe
https://hg.mozilla.org/mozilla-central/rev/8e79ee468e48
https://hg.mozilla.org/mozilla-central/rev/c69f68084e04

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot