1696533 - The Picture-in-Picture icon needs to be a little bit upper because it always interferes with the volume bar of facebook videos.

Status: NEW

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[atefg]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Video/Audio Controls' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Changing severity to S4 because this only affects Facebook videos when they are small enough that the PiP icon is lower (the video is either moved to the corner of the Facebook site using their built-in button or the video is naturally small).

Comment 4

[juraj.masiar]

"only affects Facebook videos" - you mean the biggest social network in the world? :D That's sounds pretty severe to me.
Facebook is minimizing videos automatically as you scroll down, so I would say it's pretty common use case.

And suggested solution with different placement is not exactly great, there should be a more general solution that would work on all pages.

Comment 5

[Janvi Bajoria [:janvi01]]

Hey, I would like to work on this bug as an outreachy applicant.

Comment 6

[Janvi Bajoria [:janvi01]]

Hey, decreasing the top property of pip-wrapper is making the pip icon upper and not interfering with Facebook videos. (tested locally)

(In reply to juraj.masiar from comment #4)

And suggested solution with different placement is not exactly great, there should be a more general solution that would work on all pages.

I think maybe this is not the ideal solution as mentioned but this could be a temporary solution until we think of a general solution to this.

Should I submit a patch doing these changes?
Thanks!

Comment 7

[kpatenio]

Hi Janvi,

Thanks for looking into this. I would go ahead and make a patch so that we can make an in-depth review.

Just some quick comments:
Considering that this issue is only specific to Facebook (and furthermore, only specific to smaller video dimensions in Facebook), we wouldn't want to affect the pip toggle position for all websites (ideally).

I wonder if we could use a video wrapper for Facebook.com? Ex. if a video is a particular dimension and is in Facebook.com, move the pip toggle up a bit.

Documentation is admittedly sparse at the moment for video wrappers, but we do have some comments in the code (see PictureInPictureChild), as well as a draft of video wrapper documentation (Bug 1749795 - see phabricator patch attached there).

Comment 8

[Janvi Bajoria [:janvi01]]

Hey, Thanks for looking.

(In reply to kpatenio from comment #7)

Just some quick comments:
Considering that this issue is only specific to Facebook (and furthermore, only specific to smaller video dimensions in Facebook), we wouldn't want to affect the pip toggle position for all websites (ideally).

I wonder if we could use a video wrapper for Facebook.com? Ex. if a video is a particular dimension and is in Facebook.com, move the pip toggle up a bit.

Documentation is admittedly sparse at the moment for video wrappers, but we do have some comments in the code (see PictureInPictureChild), as well as a draft of video wrapper documentation (Bug 1749795 - see phabricator patch attached there).

for site-specific, we can get the current URL and screen width and height and check if it is Facebook.com and then move the pip toggle as required.

I am looking through the code to get how we can create a video wrapper as it is a bit new for me.

Thanks!

Comment 9

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1696533 - move pip icon upper for facebook videos r?kpatenio

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 11

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D144137	Bug 1696533 - move pip icon upper for facebook videos r?kpatenio	janvi01	kpatenio: Back Jan 3, 2023

:janvi01, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.