1731986 - [clang 13] error: variable 'sample' set but not used

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-09-22T09:05:57.303Z] 09:05:57     INFO -  /builds/worker/checkouts/gecko/dom/media/platforms/wmf/WMFMediaDataDecoder.cpp(42,12): error: variable 'sample' set but not used [-Werror,-Wunused-but-set-variable]
[task 2021-09-22T09:05:57.303Z] 09:05:57     INFO -    uint32_t sample;
[task 2021-09-22T09:05:57.303Z] 09:05:57     INFO -             ^
[task 2021-09-22T09:05:57.303Z] 09:05:57     INFO -  1 error generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1731986 - Remove unused remains of WMFMediaDataDecoder telemetry.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b48d652ae5e
Remove unused remains of WMFMediaDataDecoder telemetry. r=bryce

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/9b48d652ae5e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I feel like we're eventually going to get an esr91 uplift request in this bug when some distro tries to update to clang-13 down the road. Did you want to nominate this, Mike?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

I feel like we're eventually going to get an esr91 uplift request in this bug when some distro tries to update to clang-13 down the road. Did you want to nominate this, Mike?

It's not an error by default. It's only an error because we build with -Werror, which is not recommended downstream unless they use the exact same compiler versions.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Ah, I missed that this was Werror bustage. Thanks.